Add OIDC login and per-domain authorization
Authentication previously implied full authorization: any valid token could manage every host, DNS provider, domain, and user. This adds SSO login and a per-domain rights model. OIDC login (authorization_code + PKCE): - conf.oidc + conf.auth blocks; clientSecret in (gitignored) secrets.js. - utils/oidc.js (state/PKCE, code exchange, userinfo) using global fetch. - models/oidc_state.js: short-lived state store, auto-expiring via model-redis 1.5 per-key TTL. - routes/auth.js: GET /auth/oidc/start + /auth/oidc/callback; JIT-provisions a local user, mints an AuthToken carrying the SSO groups, hands the token to the browser via a URL fragment. "Log in with SSO" button on the login page. Authorization (groups + app overrides, per-domain, with ownership): - models/grant.js + utils/roles.js (pure, unit-tested): effective rights from conf.auth (admin users/groups, group->role map), Grant records (user|group -> global|domain -> viewer|manager|admin), and ownership (created_by). Roles rank admin > manager(owner) > viewer. - AuthToken stores session groups; middleware/auth.js exposes req.groups. - middleware/authz.js: requireAdmin, requireDomainRole(minRole, resolveDomain), filterViewable. Applied across routes: host mutations need manager on the host's domain; reads are filtered to visible domains; DNS providers, user management, and grant management are global-admin-only; certs need viewer. - routes/grant.js: admin CRUD for grants. Anti-lockout via conf.auth.adminUsers plus migrations/grant_bootstrap.js. Frontend: /me returns effective rights; nav gates Users/Grants to admins; grants management page; OIDC token-fragment handling in app-base.js. Tests: utils/roles and utils/oidc unit-tested (no redis); wired into the test scripts. Full suite 89 pass. Also verified end-to-end against redis (grant resolution, middleware allow/deny/403, list filtering) and the OIDC pure flow. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,77 @@
|
||||
'use strict';
|
||||
|
||||
const {describe, test} = require('node:test');
|
||||
const assert = require('node:assert');
|
||||
const crypto = require('crypto');
|
||||
|
||||
const oidc = require('../../utils/oidc');
|
||||
const conf = require('@simpleworkjs/conf');
|
||||
|
||||
/**
|
||||
* Tests for the pure parts of the OIDC client (utils/oidc): PKCE/state
|
||||
* generation, authorize-URL construction, and claim mapping. Network calls
|
||||
* (exchangeCode/fetchUserInfo) are not exercised here.
|
||||
*/
|
||||
|
||||
describe('oidc PKCE / state', () => {
|
||||
test('createAuthRequest returns distinct high-entropy state and verifier', () => {
|
||||
const a = oidc.createAuthRequest();
|
||||
assert.ok(a.state.length >= 20);
|
||||
assert.ok(a.codeVerifier.length >= 20);
|
||||
assert.notStrictEqual(a.state, a.codeVerifier);
|
||||
|
||||
const b = oidc.createAuthRequest();
|
||||
assert.notStrictEqual(a.state, b.state);
|
||||
});
|
||||
|
||||
test('code challenge is the base64url S256 of the verifier', () => {
|
||||
const {codeVerifier, codeChallenge} = oidc.createAuthRequest();
|
||||
const expected = crypto.createHash('sha256').update(codeVerifier).digest('base64')
|
||||
.replace(/\+/g, '-').replace(/\//g, '_').replace(/=+$/, '');
|
||||
assert.strictEqual(codeChallenge, expected);
|
||||
});
|
||||
|
||||
test('challenge is base64url (no +, /, or = padding)', () => {
|
||||
const {codeChallenge} = oidc.createAuthRequest();
|
||||
assert.ok(!/[+/=]/.test(codeChallenge));
|
||||
});
|
||||
});
|
||||
|
||||
describe('oidc buildAuthUrl', () => {
|
||||
test('includes required authorization-code + PKCE params', () => {
|
||||
const url = new URL(oidc.buildAuthUrl('the-state', 'the-challenge'));
|
||||
assert.strictEqual(url.origin + url.pathname, conf.oidc.authorizationEndpoint);
|
||||
const p = url.searchParams;
|
||||
assert.strictEqual(p.get('response_type'), 'code');
|
||||
assert.strictEqual(p.get('client_id'), conf.oidc.clientId);
|
||||
assert.strictEqual(p.get('redirect_uri'), conf.oidc.redirectUri);
|
||||
assert.strictEqual(p.get('state'), 'the-state');
|
||||
assert.strictEqual(p.get('code_challenge'), 'the-challenge');
|
||||
assert.strictEqual(p.get('code_challenge_method'), 'S256');
|
||||
assert.ok(p.get('scope').includes('openid'));
|
||||
assert.ok(p.get('scope').includes('groups'));
|
||||
});
|
||||
});
|
||||
|
||||
describe('oidc claimsToIdentity', () => {
|
||||
test('maps preferred_username and groups', () => {
|
||||
const id = oidc.claimsToIdentity({
|
||||
sub: 'abc',
|
||||
preferred_username: 'jane',
|
||||
groups: ['dns-team', 'proxy-admins'],
|
||||
});
|
||||
assert.strictEqual(id.username, 'jane');
|
||||
assert.deepStrictEqual(id.groups, ['dns-team', 'proxy-admins']);
|
||||
});
|
||||
|
||||
test('falls back to sub when no preferred_username', () => {
|
||||
const id = oidc.claimsToIdentity({sub: 'abc'});
|
||||
assert.strictEqual(id.username, 'abc');
|
||||
assert.deepStrictEqual(id.groups, []);
|
||||
});
|
||||
|
||||
test('coerces a single group value to an array', () => {
|
||||
const id = oidc.claimsToIdentity({sub: 'abc', groups: 'solo'});
|
||||
assert.deepStrictEqual(id.groups, ['solo']);
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,173 @@
|
||||
'use strict';
|
||||
|
||||
const {describe, test} = require('node:test');
|
||||
const assert = require('node:assert');
|
||||
|
||||
const roles = require('../../utils/roles');
|
||||
|
||||
/**
|
||||
* Tests for the pure authorization logic (utils/roles). No redis: grant rows,
|
||||
* owned domains, and conf.auth are passed in directly. This is the heart of the
|
||||
* per-domain rights model — see models/grant.js for the redis-backed wiring.
|
||||
*/
|
||||
|
||||
const authConf = {
|
||||
adminUsers: ['root'],
|
||||
adminGroups: ['proxy-admins'],
|
||||
groupRoleMap: {
|
||||
'global-viewers': {scope: 'global', role: 'viewer'},
|
||||
'foo-managers': {scope: 'domain', domain: 'foo.com', role: 'manager'},
|
||||
'super': {scope: 'global', role: 'admin'},
|
||||
},
|
||||
};
|
||||
|
||||
const effective = (identity, data) =>
|
||||
roles.resolveEffective(identity, {authConf, ...data});
|
||||
|
||||
describe('roles.resolveEffective', () => {
|
||||
|
||||
describe('admin', () => {
|
||||
test('conf adminUsers grants global admin', () => {
|
||||
const e = effective({username: 'root', groups: []});
|
||||
assert.strictEqual(e.isAdmin, true);
|
||||
});
|
||||
|
||||
test('conf adminGroups grants global admin', () => {
|
||||
const e = effective({username: 'bob', groups: ['proxy-admins']});
|
||||
assert.strictEqual(e.isAdmin, true);
|
||||
});
|
||||
|
||||
test('groupRoleMap admin role grants global admin', () => {
|
||||
const e = effective({username: 'bob', groups: ['super']});
|
||||
assert.strictEqual(e.isAdmin, true);
|
||||
});
|
||||
|
||||
test('a global admin Grant record grants admin', () => {
|
||||
const e = effective({username: 'bob', groups: []}, {
|
||||
grants: [{subjectType: 'user', subject: 'bob', scope: 'global', role: 'admin'}],
|
||||
});
|
||||
assert.strictEqual(e.isAdmin, true);
|
||||
});
|
||||
|
||||
test('admin passes every domain check', () => {
|
||||
const e = effective({username: 'root', groups: []});
|
||||
assert.strictEqual(roles.allows(e, 'manager', 'anything.com'), true);
|
||||
assert.strictEqual(roles.roleForDomain(e, 'anything.com'), 'admin');
|
||||
});
|
||||
|
||||
test('a plain user is not admin', () => {
|
||||
const e = effective({username: 'nobody', groups: []});
|
||||
assert.strictEqual(e.isAdmin, false);
|
||||
});
|
||||
});
|
||||
|
||||
describe('per-domain grants', () => {
|
||||
test('user manager grant allows manage on that domain only', () => {
|
||||
const e = effective({username: 'jane', groups: []}, {
|
||||
grants: [{subjectType: 'user', subject: 'jane', scope: 'domain', domain: 'ex.com', role: 'manager'}],
|
||||
});
|
||||
assert.strictEqual(roles.allows(e, 'manager', 'ex.com'), true);
|
||||
assert.strictEqual(roles.allows(e, 'viewer', 'ex.com'), true);
|
||||
assert.strictEqual(roles.allows(e, 'manager', 'other.com'), false);
|
||||
assert.strictEqual(roles.allows(e, 'viewer', 'other.com'), false);
|
||||
});
|
||||
|
||||
test('viewer grant allows read but not manage', () => {
|
||||
const e = effective({username: 'jane', groups: []}, {
|
||||
grants: [{subjectType: 'user', subject: 'jane', scope: 'domain', domain: 'ex.com', role: 'viewer'}],
|
||||
});
|
||||
assert.strictEqual(roles.allows(e, 'viewer', 'ex.com'), true);
|
||||
assert.strictEqual(roles.allows(e, 'manager', 'ex.com'), false);
|
||||
});
|
||||
|
||||
test('group grant applies to members', () => {
|
||||
const e = effective({username: 'jane', groups: ['dns-team']}, {
|
||||
grants: [{subjectType: 'group', subject: 'dns-team', scope: 'domain', domain: 'ex.com', role: 'manager'}],
|
||||
});
|
||||
assert.strictEqual(roles.allows(e, 'manager', 'ex.com'), true);
|
||||
});
|
||||
|
||||
test('group grant does not apply to non-members', () => {
|
||||
const e = effective({username: 'jane', groups: []}, {
|
||||
grants: [{subjectType: 'group', subject: 'dns-team', scope: 'domain', domain: 'ex.com', role: 'manager'}],
|
||||
});
|
||||
assert.strictEqual(roles.allows(e, 'viewer', 'ex.com'), false);
|
||||
});
|
||||
|
||||
test('groupRoleMap domain default applies', () => {
|
||||
const e = effective({username: 'jane', groups: ['foo-managers']});
|
||||
assert.strictEqual(roles.allows(e, 'manager', 'foo.com'), true);
|
||||
assert.strictEqual(roles.allows(e, 'manager', 'bar.com'), false);
|
||||
});
|
||||
});
|
||||
|
||||
describe('override precedence (strongest wins)', () => {
|
||||
test('a per-user manager grant beats a group viewer grant', () => {
|
||||
const e = effective({username: 'jane', groups: ['team']}, {
|
||||
grants: [
|
||||
{subjectType: 'group', subject: 'team', scope: 'domain', domain: 'ex.com', role: 'viewer'},
|
||||
{subjectType: 'user', subject: 'jane', scope: 'domain', domain: 'ex.com', role: 'manager'},
|
||||
],
|
||||
});
|
||||
assert.strictEqual(roles.roleForDomain(e, 'ex.com'), 'manager');
|
||||
});
|
||||
|
||||
test('grant order does not matter (max wins)', () => {
|
||||
const e = effective({username: 'jane', groups: []}, {
|
||||
grants: [
|
||||
{subjectType: 'user', subject: 'jane', scope: 'domain', domain: 'ex.com', role: 'manager'},
|
||||
{subjectType: 'user', subject: 'jane', scope: 'domain', domain: 'ex.com', role: 'viewer'},
|
||||
],
|
||||
});
|
||||
assert.strictEqual(roles.roleForDomain(e, 'ex.com'), 'manager');
|
||||
});
|
||||
});
|
||||
|
||||
describe('ownership', () => {
|
||||
test('owned domains grant manager without an explicit grant', () => {
|
||||
const e = effective({username: 'owner', groups: []}, {
|
||||
ownedDomains: ['mine.com'],
|
||||
});
|
||||
assert.strictEqual(roles.roleForDomain(e, 'mine.com'), 'manager');
|
||||
assert.strictEqual(roles.allows(e, 'manager', 'mine.com'), true);
|
||||
assert.strictEqual(roles.allows(e, 'viewer', 'notmine.com'), false);
|
||||
});
|
||||
});
|
||||
|
||||
describe('global (non-admin) roles', () => {
|
||||
test('global viewer sees every domain read-only', () => {
|
||||
const e = effective({username: 'v', groups: ['global-viewers']});
|
||||
assert.strictEqual(e.global, 'viewer');
|
||||
assert.strictEqual(roles.allows(e, 'viewer', 'a.com'), true);
|
||||
assert.strictEqual(roles.allows(e, 'viewer', 'b.com'), true);
|
||||
assert.strictEqual(roles.allows(e, 'manager', 'a.com'), false);
|
||||
});
|
||||
});
|
||||
|
||||
describe('visibleDomains', () => {
|
||||
test('lists domains with at least viewer', () => {
|
||||
const e = effective({username: 'jane', groups: []}, {
|
||||
grants: [
|
||||
{subjectType: 'user', subject: 'jane', scope: 'domain', domain: 'a.com', role: 'viewer'},
|
||||
{subjectType: 'user', subject: 'jane', scope: 'domain', domain: 'b.com', role: 'manager'},
|
||||
],
|
||||
});
|
||||
assert.deepStrictEqual(roles.visibleDomains(e).sort(), ['a.com', 'b.com']);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe('roles.rank / maxRole', () => {
|
||||
test('rank ordering', () => {
|
||||
assert.ok(roles.rank('admin') > roles.rank('manager'));
|
||||
assert.ok(roles.rank('manager') > roles.rank('viewer'));
|
||||
assert.ok(roles.rank('viewer') > roles.rank(null));
|
||||
});
|
||||
|
||||
test('maxRole returns the stronger role', () => {
|
||||
assert.strictEqual(roles.maxRole('viewer', 'manager'), 'manager');
|
||||
assert.strictEqual(roles.maxRole('manager', 'viewer'), 'manager');
|
||||
assert.strictEqual(roles.maxRole(null, 'viewer'), 'viewer');
|
||||
assert.strictEqual(roles.maxRole(null, null), null);
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user