Fix jQuery 4 removed-API usage in app-base.js

jQuery 4 removed $.isFunction and $.holdReady, which threw at runtime
("$.isFunction is not a function" on the Clear Cache / delete path).

- Replace the three $.isFunction(callback) checks with typeof === 'function'.
- Drop the two $.holdReady calls in forceLogin; the redirect already keeps
  an unauthenticated user off the page.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
2026-07-10 12:21:28 -04:00
parent 9f175f5bf6
commit f4ba086fd2
+5 -6
View File
@@ -76,7 +76,7 @@ app.api = (function(app){
var baseURL = '/api/'
function post(url, data, callback){
if(!$.isFunction(callback)) callback = callback2;
if(typeof callback !== 'function') callback = callback2;
return $.ajax({
type: 'POST',
url: baseURL+url,
@@ -97,7 +97,7 @@ app.api = (function(app){
}
function put(url, data, callback){
if(!$.isFunction(callback)) callback = callback2;
if(typeof callback !== 'function') callback = callback2;
return $.ajax({
type: 'PUT',
url: baseURL+url,
@@ -118,7 +118,7 @@ app.api = (function(app){
}
function remove(url, callback, callback2){
if(!$.isFunction(callback)) callback = callback2;
if(typeof callback !== 'function') callback = callback2;
return $.ajax({
type: 'delete',
url: baseURL+url,
@@ -214,13 +214,12 @@ app.auth = (function(app){
}
function forceLogin(){
$.holdReady(true);
// jQuery 4 removed $.holdReady; rely on the redirect below to keep an
// unauthenticated user off the page instead of pausing document ready.
app.auth.isLoggedIn(function(error, isLoggedIn){
if(error || !isLoggedIn){
app.auth.logOut(function(){})
location.replace(`/login${location.href.replace(location.origin, '')}`);
}else{
$.holdReady(false);
}
});
}