Files
proxy/nodejs/routes/user.js
T
wmantly d1586b4d5a Fix user creation and password policy (#48)
Root cause of "can't log in with new credentials": routes/user.js POST called
User.add, which doesn't exist on the redis User model (it has create) — so every
API-created account threw and was never persisted. Switch to User.create and make
the Add button a submit.

Replace the broken password rule (rejected strong "@123Caplowercase", accepted
weak "lowercase1") with a clear policy in utils/password_policy.js: >= 8 chars and
either 12+ chars or 3-of-4 character classes. Enforced server-side on create and
password changes, mirrored in public/lib/js/val.js, with unit tests.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-11 11:38:09 -04:00

124 lines
3.3 KiB
JavaScript
Executable File

'use strict';
const router = require('express').Router();
const {User} = require('../models').models;
const authz = require('../middleware/authz');
const {passwordError} = require('../utils/password_policy');
// Reject a weak password before it reaches the model. Throws 422 with a
// per-field key the frontend surfaces inline.
function validatePassword(password){
let message = passwordError(password);
if(message) throw User.errors.ObjectValidateError([{key: 'password', message}]);
}
// User management is global-admin-only, except the self-service routes below
// (GET /me, PUT /password, POST /key) which any authenticated user may call for
// their own account.
router.get('/', authz.requireAdmin, async function(req, res, next){
try{
return res.json({
results: await User[req.query.detail ? "listDetail" : "list"]()
});
}catch(error){
next(error);
}
});
router.post('/', authz.requireAdmin, async function(req, res, next){
try{
req.body.created_by = authz.reqUsername(req)
validatePassword(req.body.password);
// User.create (not the nonexistent User.add) — the drift here meant every
// API-created account threw, so the new credentials never existed to log
// in with (issue #48).
return res.json(await User.create(req.body));
}catch(error){
next(error);
}
});
router.delete('/:username', authz.requireAdmin, async function(req, res, next){
try{
let user = await User.get(req.params.username);
return res.json({username: req.params.username, results: await user.remove()})
}catch(error){
next(error);
}
});
// Self-service: the caller's own identity and effective rights. Drives the
// frontend's nav/button gating.
router.get('/me', async function(req, res, next){
try{
let effective = await authz.getEffective(req);
return res.json({
username: authz.reqUsername(req),
// Merged groups (external + local); localGroups is the app-managed
// subset, externalGroups the ones from SSO/LDAP.
groups: effective.groups || req.groups || [],
localGroups: effective.localGroups || [],
externalGroups: req.groups || [],
isAdmin: effective.isAdmin,
global: effective.global,
domains: effective.domains,
});
}catch(error){
next(error);
}
});
// Self-service: change your own password.
router.put('/password', async function(req, res, next){
try{
validatePassword(req.body.password);
return res.json({results: await req.user.setPassword(req.body)})
}catch(error){
next(error);
}
});
// Admin: reset another user's password.
router.put('/password/:username', authz.requireAdmin, async function(req, res, next){
try{
validatePassword(req.body.password);
let user = await User.get(req.params.username);
return res.json({results: await user.setPassword(req.body)});
}catch(error){
next(error);
}
});
router.post('/invite', authz.requireAdmin, async function(req, res, next){
try{
let token = await req.user.invite();
return res.json({token: token.token});
}catch(error){
next(error);
}
});
// Self-service: add an SSH key to your own account.
router.post('/key', async function(req, res, next){
try{
let added = await User.addSSHkey({
username: authz.reqUsername(req),
key: req.body.key
});
return res.status(added === true ? 200 : 400).json({
message: added
});
}catch(error){
next(error);
}
});
module.exports = router;