Fix api-tokens date display + quiet authIO no-token log (#36)
- api_tokens.ejs: created_on/last_used_on come back from Redis as strings (model-redis only coerces fields with an explicit `type`), so `new Date(ms)` yielded "Invalid date". Use `moment(ms, "x")` (the hosts.ejs/dns.ejs precedent) which parses a numeric string-or-number as a Unix-ms timestamp. - api_tokens.ejs: `isExpired` is a class getter not serialized to the client JSON, so the "expired" badge never showed — compute expiry in the view via `Date.now() > Number(expires_at)`. Also guard the `last_used_on: 0` / falsy case (string "0" is truthy) so unset timestamps render "—" not "1970". - middleware/auth.js: authIO did `checkToken(socket.handshake.auth.token || 0)`, so any socket connect without a token (login page, pre-login) did an `AuthToken.get(0)` lookup and logged a noisy `EntryNotFound` trace. Guard: reject the socket with a generic 401 when there's no token (behavior- preserving — unauth sockets were already rejected; just no Redis lookup / 404). Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
@@ -30,7 +30,12 @@ async function auth(req, res, next){
|
||||
|
||||
async function authIO(socket, next){
|
||||
try{
|
||||
let token = await Auth.checkToken(socket.handshake.auth.token || 0);
|
||||
// No token in the handshake (e.g. a page hit before login, or a socket
|
||||
// opened while logged out) → reject the socket cleanly without doing an
|
||||
// AuthToken.get(0) lookup that throws a noisy EntryNotFound trace.
|
||||
let tok = socket.handshake.auth && socket.handshake.auth.token;
|
||||
if(!tok) return next(Auth.errors.login());
|
||||
let token = await Auth.checkToken(tok);
|
||||
socket.user = await token.getUser();
|
||||
next();
|
||||
}catch(error){
|
||||
|
||||
Reference in New Issue
Block a user