From b46b3bed80b7dbef85f9595419f8037653ff429a Mon Sep 17 00:00:00 2001 From: William Mantly Date: Mon, 3 Aug 2026 22:19:38 -0400 Subject: [PATCH] fix: use app.messages.confirm instead of native confirm() in vault Shared tab The no_native_dialogs regression test forbids native alert/confirm/prompt in views (they block browser events). Replace the native confirm() in deleteShared with app.messages.confirm(). --- nodejs/views/vault.ejs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/nodejs/views/vault.ejs b/nodejs/views/vault.ejs index 54afd78..03fdc8f 100644 --- a/nodejs/views/vault.ejs +++ b/nodejs/views/vault.ejs @@ -543,7 +543,8 @@ curl "$VAULT_ADDR/v1/secret/data/apps//conf" } async function deleteShared(id) { - if (!confirm('Delete this shared secret? Grantees will immediately lose access.')) return; + const confirmed = await app.messages.confirm('Delete this shared secret? Grantees will immediately lose access.', $('#shared-mine-list'), 'warning'); + if (!confirmed) return; try { await sharedApi('/' + id, 'DELETE'); await loadShared(); } catch (e) { app.messages.toast('Error deleting: ' + e.message, 'danger'); } }