wmantly
a78db906e8
Mail sending fell back to a hardcoded noreply@theta42.com From address when smtp.from wasn't set, which authenticated relays reject with "Sender is not same as SMTP authenticate username" since no relay authorized this account to send as that address. Falls back to smtp.user first now. Also: catalog card titles now read name-then-icon instead of icon-then-name, and a handful of docs corrections found in an accuracy pass (configuration.md missing the OpenBao/live-config layer, plugins.md undercounting plugin types, vault.md describing OpenBao dev-mode/root-token access that doesn't reflect the real production setup, orphaned discovery.md/vault.md pages linked in, README's required-groups list missing app_sso_directory_admin). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0113gCdnfSCuZr6xvPDxTo3D
73 lines
2.2 KiB
JavaScript
73 lines
2.2 KiB
JavaScript
'use strict';
|
|
|
|
const nodemailer = require('nodemailer');
|
|
const mustache = require('mustache');
|
|
const conf = require('@simpleworkjs/conf');
|
|
|
|
var Mail = {};
|
|
|
|
Mail.send = function(to, subject, message, from){
|
|
// Never let the automated test suite deliver real mail — tests run against
|
|
// this app's real routes (notification broadcast, password reset, invite,
|
|
// OTP-by-email, …) with NODE_ENV=test, and any of them resolving a real
|
|
// recipient list must not actually hit SMTP. Tests already tolerate this
|
|
// (see e.g. tests/misc.test.js: "SMTP failure is non-fatal") since none
|
|
// assert on real delivery.
|
|
if(conf.environment === 'test'){
|
|
return Promise.resolve({accepted: [], rejected: [], response: 'skipped: NODE_ENV=test'});
|
|
}
|
|
|
|
return new Promise(function(resolve, reject){
|
|
var transportOpts = {
|
|
host: conf.smtp.host || 'localhost',
|
|
port: conf.smtp.port || 25,
|
|
secure: conf.smtp.secure !== undefined ? conf.smtp.secure : false
|
|
};
|
|
|
|
if (conf.smtp.user && conf.smtp.pass) {
|
|
transportOpts.auth = {
|
|
user: conf.smtp.user,
|
|
pass: conf.smtp.pass
|
|
};
|
|
}
|
|
|
|
var transporter = nodemailer.createTransport(transportOpts);
|
|
|
|
// Most authenticated SMTP relays (and this bit the field: "554 5.7.1
|
|
// ...: Sender is not same as SMTP authenticate username") require the
|
|
// envelope/header From to equal the authenticated user, or reject the
|
|
// send outright. If the operator hasn't set an explicit smtp.from,
|
|
// defaulting to the SMTP username is far more likely to actually send
|
|
// than a made-up noreply@theta42.com address that no relay authorized
|
|
// this account to send as.
|
|
var mailOpts = {
|
|
from: from || conf.smtp.from || conf.smtp.user || `${conf.name} Accounts <noreply@theta42.com>`,
|
|
to: to,
|
|
subject: subject,
|
|
html: message
|
|
};
|
|
|
|
transporter.sendMail(mailOpts, function(err, info){
|
|
if (err) {
|
|
reject(err);
|
|
} else {
|
|
resolve(info);
|
|
}
|
|
});
|
|
});
|
|
};
|
|
|
|
|
|
Mail.sendTemplate = async function(to, template, context, from){
|
|
context.name = conf.name;
|
|
template = require(`../views/email_templates/${template}`);
|
|
await Mail.send(
|
|
to,
|
|
mustache.render(template.subject, context),
|
|
mustache.render(template.message, context),
|
|
from || (template.from && mustache.render(template.from, context))
|
|
)
|
|
};
|
|
|
|
module.exports = {Mail};
|