Compare commits
3 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 7d1cfd08a5 | |||
| 52379c2434 | |||
| 48d17e0e9f |
@@ -5,6 +5,11 @@ All notable changes to the `theta-agent` daemon will be documented in this file.
|
|||||||
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
|
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
|
||||||
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
|
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
|
||||||
|
|
||||||
|
## [v1.3.0] - 2026-08-04
|
||||||
|
|
||||||
|
### Fixed
|
||||||
|
- **Silently ignore `heartbeat_ack`** — the server replies to the agent's own periodic heartbeat with `heartbeat_ack`. The agent had no case for it, so it fell through to the unknown-command handler, logged `Unknown command type: heartbeat_ack` every minute, and answered with a spurious error response. Heartbeat acks are fire-and-forget; the agent now ignores them silently.
|
||||||
|
|
||||||
## [v1.2.0] - 2026-08-03
|
## [v1.2.0] - 2026-08-03
|
||||||
|
|
||||||
### Added
|
### Added
|
||||||
|
|||||||
Binary file not shown.
+12
-1
@@ -139,7 +139,11 @@ func connectWebSocket(cm *ConfigManager, exec Executor) {
|
|||||||
|
|
||||||
func handleCommand(cm *ConfigManager, msg WSMessage, c MessageWriter, exec Executor) {
|
func handleCommand(cm *ConfigManager, msg WSMessage, c MessageWriter, exec Executor) {
|
||||||
cfg := cm.Get()
|
cfg := cm.Get()
|
||||||
log.Printf("Received command: %s", msg.Type)
|
// Don't log the server's fire-and-forget heartbeat ack — it arrives every
|
||||||
|
// 60s and is not a command to act on; logging it is pure per-minute noise.
|
||||||
|
if msg.Type != "heartbeat_ack" {
|
||||||
|
log.Printf("Received command: %s", msg.Type)
|
||||||
|
}
|
||||||
|
|
||||||
sendResponse := func(status string, message string) {
|
sendResponse := func(status string, message string) {
|
||||||
resp, _ := json.Marshal(map[string]string{"status": status, "message": message})
|
resp, _ := json.Marshal(map[string]string{"status": status, "message": message})
|
||||||
@@ -311,6 +315,13 @@ func handleCommand(cm *ConfigManager, msg WSMessage, c MessageWriter, exec Execu
|
|||||||
respPayload, _ := json.Marshal(resp)
|
respPayload, _ := json.Marshal(resp)
|
||||||
c.WriteMessage(websocket.TextMessage, respPayload)
|
c.WriteMessage(websocket.TextMessage, respPayload)
|
||||||
return
|
return
|
||||||
|
// heartbeat_ack is the server's acknowledgement of the agent's own periodic
|
||||||
|
// heartbeat (the agent sends `heartbeat`, the server answers `heartbeat_ack`).
|
||||||
|
// There is nothing to do with it -- it is not a command to run, and answering
|
||||||
|
// an ack with an error response would inject spurious errors into the
|
||||||
|
// command-response channel every minute. Silently ignore.
|
||||||
|
case "heartbeat_ack":
|
||||||
|
return
|
||||||
default:
|
default:
|
||||||
log.Printf("Unknown command type: %s", msg.Type)
|
log.Printf("Unknown command type: %s", msg.Type)
|
||||||
sendResponse("error", "unknown command type")
|
sendResponse("error", "unknown command type")
|
||||||
|
|||||||
@@ -51,6 +51,9 @@ func TestHandleCommand(t *testing.T) {
|
|||||||
expectedCmd []string
|
expectedCmd []string
|
||||||
expectedFile string
|
expectedFile string
|
||||||
expectedFileCont string
|
expectedFileCont string
|
||||||
|
// heartbeat_ack (and any fire-and-forget ack) must be silently ignored —
|
||||||
|
// no response message, no command, no log noise.
|
||||||
|
expectedNoResponse bool
|
||||||
}{
|
}{
|
||||||
{
|
{
|
||||||
name: "config command success",
|
name: "config command success",
|
||||||
@@ -175,6 +178,16 @@ func TestHandleCommand(t *testing.T) {
|
|||||||
expectedStatus: "error",
|
expectedStatus: "error",
|
||||||
expectedCmd: nil,
|
expectedCmd: nil,
|
||||||
},
|
},
|
||||||
|
{
|
||||||
|
name: "heartbeat_ack is silently ignored",
|
||||||
|
cfg: &Config{
|
||||||
|
Capabilities: Capabilities{},
|
||||||
|
},
|
||||||
|
msg: WSMessage{
|
||||||
|
Type: "heartbeat_ack",
|
||||||
|
},
|
||||||
|
expectedNoResponse: true,
|
||||||
|
},
|
||||||
{
|
{
|
||||||
name: "unknown command",
|
name: "unknown command",
|
||||||
cfg: &Config{
|
cfg: &Config{
|
||||||
@@ -194,6 +207,16 @@ func TestHandleCommand(t *testing.T) {
|
|||||||
cm := &ConfigManager{current: tc.cfg}
|
cm := &ConfigManager{current: tc.cfg}
|
||||||
handleCommand(cm, tc.msg, mockConn, mockExec)
|
handleCommand(cm, tc.msg, mockConn, mockExec)
|
||||||
|
|
||||||
|
if tc.expectedNoResponse {
|
||||||
|
if len(mockConn.Messages) != 0 {
|
||||||
|
t.Fatalf("expected no response message, got %d: %v", len(mockConn.Messages), mockConn.Messages)
|
||||||
|
}
|
||||||
|
if len(mockExec.ExecutedCommands) > 0 {
|
||||||
|
t.Errorf("expected no commands to be executed, but got %v", mockExec.ExecutedCommands)
|
||||||
|
}
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
if len(mockConn.Messages) != 1 {
|
if len(mockConn.Messages) != 1 {
|
||||||
t.Fatalf("expected 1 response message, got %d", len(mockConn.Messages))
|
t.Fatalf("expected 1 response message, got %d", len(mockConn.Messages))
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user