From 994e8f22221c3998337f2b604db2e2d5fa6d2592 Mon Sep 17 00:00:00 2001 From: Georgi Gerganov Date: Mon, 5 Oct 2026 16:04:47 +0300 Subject: [PATCH] ci : add "Require Docker" flag to make-release workflow (#29989) Assisted-by: pi:llama.cpp/Qwen3.8-27B --- .github/workflows/make-release.yml | 6 ++++++ scripts/make-release-checks.sh | 3 +++ 2 files changed, 9 insertions(+) diff --git a/.github/workflows/make-release.yml b/.github/workflows/make-release.yml index 93df37f0e..1e2f93960 100644 --- a/.github/workflows/make-release.yml +++ b/.github/workflows/make-release.yml @@ -18,6 +18,11 @@ on: required: false type: boolean default: false + require_docker: + description: 'Require the Docker workflow to have completed successfully' + required: true + type: boolean + default: true apiabi_compare_tag: description: 'Tag to compare against for API/ABI check (default: latest release)' required: false @@ -56,6 +61,7 @@ jobs: RELEASE_BRANCH: ${{ github.ref_name }} SKIP_APIABI_CHECK: ${{ github.event.inputs.skip_apiabi_check }} APIABI_COMPARE_TAG: ${{ github.event.inputs.apiabi_compare_tag }} + REQUIRE_DOCKER: ${{ github.event.inputs.require_docker }} - name: Create release tag if: ${{ github.event.inputs.dry_run == 'false' }} diff --git a/scripts/make-release-checks.sh b/scripts/make-release-checks.sh index 2b60e870f..c0b81a170 100755 --- a/scripts/make-release-checks.sh +++ b/scripts/make-release-checks.sh @@ -8,6 +8,7 @@ # GH_TOKEN, GITHUB_REPOSITORY, GITHUB_OUTPUT # RELEASE_BRANCH: when set, HEAD must belong to origin/RELEASE_BRANCH and must # not be older than 3 days from the branch HEAD (skipped when unset) +# REQUIRE_DOCKER: set to "false" to skip the container image check (default: true) set -euo pipefail SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" @@ -126,6 +127,8 @@ if [[ -z "${NIGHTLY_TAG}" ]]; then echo "Warning: no nightly tag points at ${SHA} - skipping container image check" elif [[ -z "${GITHUB_REPOSITORY:-}" ]]; then echo "Warning: GITHUB_REPOSITORY not set - skipping container image check (local run)" +elif [[ "${REQUIRE_DOCKER:-true}" != "true" ]]; then + echo "Require Docker is disabled - skipping container image check" else CONTAINER_REPO="${GITHUB_REPOSITORY,,}" # lower-case owner/repo for ghcr.io GHCR_TOKEN="$(curl -fsSL \