From 2fc3e17d0c0cdcb30427492801ec0aaa12c27a72 Mon Sep 17 00:00:00 2001 From: William Mantly Date: Tue, 26 Sep 2023 00:37:57 +0000 Subject: [PATCH] Update 03-roman-numerals/roman.py --- 03-roman-numerals/roman.py | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/03-roman-numerals/roman.py b/03-roman-numerals/roman.py index d884199..57dcb9c 100644 --- a/03-roman-numerals/roman.py +++ b/03-roman-numerals/roman.py @@ -1,19 +1,20 @@ -def roman( self ): +def roman( amount ): romanNum = [] - symbols = ( ( 'M', 1000 ), ( 'C', 100 ), ( 'XC', 90 ), ( 'L', 50 ), ( 'X', 10 ), - ( 'IX', 9 ), ('V', 5 ) , ( 'IV', 4 ), ( 'I', 1 ) ) + symbols = ( + ( 'M', 1000 ), + ( 'C', 100 ), + ( 'XC', 90 ), + ( 'L', 50 ), + ( 'X', 10 ), + ( 'IX', 9 ), + ('V', 5 ) , + ( 'IV', 4 ), + ( 'I', 1 ) + ) for symbol, value in symbols: - while self >= value: - self -= value + while amount >= value: + amount -= value romanNum.append( symbol ) - return ''.join( romanNum ) - -assert roman( 11 ) == "XI", "11 should return XI" -assert roman( 60 ) == "LX", "60 should return LX" -assert roman( 78 ) == "LXXVIII", "78 should return LXXVIII" -assert roman( 4 ) == "IV", "4 should return IV" -assert roman( 99 ) == "XCIX", "99 should return XCIX" - -# Add your own assert tests below \ No newline at end of file + return ''.join( romanNum ) \ No newline at end of file