theta42/proxy
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix jQuery 4 removed-API usage in app-base.js

Browse Source 
jQuery 4 removed $.isFunction and $.holdReady, which threw at runtime
("$.isFunction is not a function" on the Clear Cache / delete path).

- Replace the three $.isFunction(callback) checks with typeof === 'function'.
- Drop the two $.holdReady calls in forceLogin; the redirect already keeps
  an unauthenticated user off the page.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
William Mantly
2026-07-10 12:21:28 -04:00
parent 9f175f5bf6
commit f4ba086fd2
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
nodejs/public/lib/js/app-base.js
+5 -6
View File
@@ -76,7 +76,7 @@ app.api = (function(app){
var baseURL = '/api/' var baseURL = '/api/'
function post(url, data, callback){ function post(url, data, callback){
if(!$.isFunction(callback)) callback = callback2; if(typeof callback !== 'function') callback = callback2;
return $.ajax({ return $.ajax({
type: 'POST', type: 'POST',
url: baseURL+url, url: baseURL+url,
@@ -97,7 +97,7 @@ app.api = (function(app){
} }
function put(url, data, callback){ function put(url, data, callback){
if(!$.isFunction(callback)) callback = callback2; if(typeof callback !== 'function') callback = callback2;
return $.ajax({ return $.ajax({
type: 'PUT', type: 'PUT',
url: baseURL+url, url: baseURL+url,
@@ -118,7 +118,7 @@ app.api = (function(app){
} }
function remove(url, callback, callback2){ function remove(url, callback, callback2){
if(!$.isFunction(callback)) callback = callback2; if(typeof callback !== 'function') callback = callback2;
return $.ajax({ return $.ajax({
type: 'delete', type: 'delete',
url: baseURL+url, url: baseURL+url,
@@ -214,13 +214,12 @@ app.auth = (function(app){
} }
function forceLogin(){ function forceLogin(){
$.holdReady(true); // jQuery 4 removed $.holdReady; rely on the redirect below to keep an
// unauthenticated user off the page instead of pausing document ready.
app.auth.isLoggedIn(function(error, isLoggedIn){ app.auth.isLoggedIn(function(error, isLoggedIn){
if(error || !isLoggedIn){ if(error || !isLoggedIn){
app.auth.logOut(function(){}) app.auth.logOut(function(){})
location.replace(`/login${location.href.replace(location.origin, '')}`); location.replace(`/login${location.href.replace(location.origin, '')}`);
}else{
$.holdReady(false);
} }
}); });
} }