Merge pull request #188 from theta42/release/1.5.3

Release 1.5.3
Release 1.5.3: fix HTML-escaped loading indicator
2026-07-28 13:38:28 -04:00 · 2026-07-28 13:31:39 -04:00 · 2026-07-28 13:07:46 -04:00 · 2026-07-28 12:52:39 -04:00
3 changed files with 10 additions and 8 deletions
@@ -6,6 +6,11 @@ correspond to git tags (`vX.Y.Z`) and `nodejs/package.json`'s `version`.

 ## [Unreleased]

+## [1.5.3] - 2026-07-28
+
+### Fixed
+- **`formAJAX`'s loading indicator showed literal HTML**, not a spinner — same fix as sso-manager-node's companion release. Replaced with plain text.
+
 ## [1.5.2] - 2026-07-28

 ### Added
@@ -1,6 +1,6 @@
 {
  "name": "proxy-api",
-  "version": "1.5.2",
+  "version": "1.5.3",
  "author": [
    {
      "name": "William Mantly",
@@ -679,13 +679,10 @@ function formAJAX(btn){
 		return false;
 	}

-	app.messages.action(
-		`<div class="spinner-border" role="status">
-			<span class="visually-hidden">Loading...</span>
-		</div>`,
-		$form,
-		'info'
-	);
+	// Plain text: app.messages.action HTML-escapes its message (by design,
+	// see @simpleworkjs/frontend), so raw markup like a spinner <div> would
+	// render literally instead of as an element.
+	app.messages.action('Saving…', $form, 'info');

 	app.api[method]($form.attr('action'), formData, function(error, data){
 		app.messages.action(data.message, $form, error ? 'danger' : 'success'); //re-populate table
Author	SHA1	Message	Date
wmantly	44c2ec3fdd	Merge pull request #188 from theta42/release/1.5.3 Release 1.5.3	2026-07-28 13:38:28 -04:00
wmantly	e9032ec4fb	Release 1.5.3: fix HTML-escaped loading indicator Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-07-28 13:31:39 -04:00
wmantly	a6e745cfc1	Merge pull request #187 from theta42/fix/loading-message-html-escaped Fix HTML-escaped loading indicator in formAJAX	2026-07-28 13:07:46 -04:00
wmantly	8350ab9b57	Fix HTML-escaped loading indicator in formAJAX Same fix as sso-manager-node: formAJAX's loading indicator passed a raw <div class="spinner-border"> string to app.messages.action, which HTML-escapes its message by design (@simpleworkjs/frontend) -- so every form submit briefly showed the literal markup as text instead of a spinner. Replaced with plain text ("Saving…"). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-07-28 12:52:39 -04:00