Files
proxy/ops/nginx_conf/targetinfo.lua
T
wmantly cd0cc50a19 Fix HTTP/2 coalescing cross-routing in targetinfo.lua
Hosts that share one wildcard cert (e.g. hassio.718it.biz and
metrics.718it.biz under *.718it.biz) resolve to the same IP, so browsers
coalesce them onto a single HTTP/2 connection. The SSL request_domain
phase resolves the connection's first host and caches it in
ngx.ctx.targetInfo; the unguarded `if targetInfo then return targetInfo`
then handed that first host's target to every coalesced request on the
connection -- e.g. hassio.718it.biz served from metrics' 192.168.1.8:8088.

Confirmed via debug logging: for GET requests to hassio.718it.biz on a
coalesced connection, ngx.ctx already held metrics' IP and the function
short-circuited to it.

Guard the reuse by host: only return the cached target when
ngx.ctx.targetInfo_domain matches the requested domain, and record that
domain whenever a target is resolved. A coalesced request for a different
host now re-resolves against its actual Host header.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-10 13:05:43 -04:00

88 lines
2.8 KiB
Lua

local M = {}
-- Function to connect to a Unix socket
local function connect(path)
local socket = require("socket.unix")()
assert(socket:settimeout(.1))
local status, err = pcall(function() assert(socket:connect(path)) end)
if status then return true end
return false
end
print("In targetInfo module")
-- Main function of the module
function M.get(ngx, domain, targetInfo)
-- Reuse a previously-resolved target ONLY when it was resolved for this
-- exact host. HTTP/2 connection coalescing lets a browser serve several
-- hostnames that share one wildcard cert (e.g. *.718it.biz) over a single
-- connection; the SSL phase (request_domain) resolves and caches the
-- connection's first host in ngx.ctx.targetInfo. Without the domain check
-- below, every coalesced request on that connection would be handed the
-- first host's target -- e.g. hassio.718it.biz served from metrics.718it.biz.
if targetInfo and ngx.ctx.targetInfo_domain == domain then
return targetInfo
end
local json = require "cjson"
local redis = require "resty.redis"
if not domain then
ngx.exit(499)
return false
end
local red = redis:new()
red:set_timeout(1000) -- 1 second
local ok, err = red:connect("127.0.0.1", 6379)
if not ok then
ngx.log(ngx.ERR, "failed to connect to redis: ", err)
return ngx.exit(598)
end
local res, err = red:hgetall("proxy_Host_"..domain)
res = red:array_to_hash(res)
-- Return the connection to the pool instead of closing it, so it can be
-- reused by later requests. Without this a new connection is opened per
-- request and never released, exhausting sockets under load.
local ok, err = red:set_keepalive(10000, 100)
if not ok then
ngx.log(ngx.ERR, "failed to set redis keepalive: ", err)
end
if not res["ip"] then
if connect("/var/run/proxy_lookup.socket") then
local socket = require("socket.unix")()
assert(socket:settimeout(.1))
assert(socket:connect("/var/run/proxy_lookup.socket"))
assert(socket:send(json.encode({domain = domain})))
while true do
local s, status, partial = socket:receive()
if partial then
res = json.decode(partial)
socket:close()
break
end
end
end
end
if not res["ip"] then
ngx.exit(406)
return false
end
ngx.ctx.targetInfo = res
-- Remember which host this target was resolved for, so the reuse guard at
-- the top can tell a genuine cache hit from a coalesced request for a
-- different host on the same connection.
ngx.ctx.targetInfo_domain = domain
ngx.ctx.toAllow = true
return res
end
return M