wmantly
2c3ec4e967
Three independent copies of the same bug: routes/discovery.js's POST /discovery/promote/:slug (the actual "Promote" button in the UI) and services/discovery_reconciler.js's autoPromote path both called ResourceGroup.create() directly with no existence check -- unlike routes/api_directory_admin.js's own ensureResourceGroup, which already carried a comment describing this exact "groups appear 3x" bug and fixing it, just not everywhere it occurred. ResourceGroup has no DB unique constraint on (resourceId, groupCn), so a resource promoted more than once (retried UI click, or the same LXC discovered from multiple Proxmox cluster nodes) silently accumulated duplicate access/admin rows every time. Added ResourceGroup.ensure() (the existing check-then-create pattern, now on the model) and switched all three call sites to it. New regression test in tests/reconciler.test.js. Also: GET /api/directory-admin/resources ran a full group-model self-heal fan-out (ensureSiteGroups per site + provisionResourceGroups per resource, each several sequential LDAP round-trips) unconditionally on every single list -- confirmed via code read as the actual bottleneck once a directory has more than a handful of resources, not data volume. Moved healing to where resources actually change instead (POST/PUT /resources, POST /discovery/promote/:slug -- PUT had none at all before this), and added POST /resources/heal-groups as an explicit on-demand equivalent for backfilling a directory seeded before this change.
71 lines
1.9 KiB
JSON
Executable File
71 lines
1.9 KiB
JSON
Executable File
{
|
|
"name": "t42-theta-directory",
|
|
"version": "2.5.0",
|
|
"description": "A very simple LDAP management and SSO system",
|
|
"author": [
|
|
{
|
|
"name": "William Mantly",
|
|
"email": "wmantly@gmail.com"
|
|
}
|
|
],
|
|
"scripts": {
|
|
"start": "node ./bin/www",
|
|
"dev": "npx nodemon --ignore public/ ./bin/www",
|
|
"test": "NODE_ENV=test jest tests/groups.test.js tests/subtypes.test.js tests/site_join.test.js tests/site_config.test.js tests/site_replicate.test.js tests/proxy_client.test.js tests/reconciler.test.js --forceExit"
|
|
},
|
|
"jest": {
|
|
"testEnvironment": "node",
|
|
"testMatch": [
|
|
"**/tests/**/*.test.js"
|
|
],
|
|
"globalSetup": "./tests/globalSetup.js"
|
|
},
|
|
"dependencies": {
|
|
"@fortawesome/fontawesome-free": "^7.3.0",
|
|
"@popperjs/core": "^2.11.8",
|
|
"@simpleworkjs/app-stack": "^1.0.0",
|
|
"@simpleworkjs/bao-conf": "^1.0.1",
|
|
"@simpleworkjs/conf": "^1.2.0",
|
|
"@simpleworkjs/directory-schema": "^1.1.0",
|
|
"@simpleworkjs/frontend": "^0.2.7",
|
|
"@simpleworkjs/ldap": "^1.0.0",
|
|
"@simpleworkjs/orm": "^0.2.8",
|
|
"bcrypt": "^6.0.0",
|
|
"bootstrap": "^5.3.8",
|
|
"bullmq": "^6.0.3",
|
|
"compression": "^1.8.1",
|
|
"ejs": "^3.1.10",
|
|
"express": "^5.2.1",
|
|
"express-rate-limit": "^8.5.2",
|
|
"extend": "^3.0.2",
|
|
"http-proxy-middleware": "^2.0.10",
|
|
"ioredis": "^6.0.0",
|
|
"jq-repeat": "^2.2.0",
|
|
"jquery": "^4.0.0",
|
|
"jsonwebtoken": "^9.0.3",
|
|
"ldapts": "^8.1.8",
|
|
"lru-cache": "^11.5.1",
|
|
"marked": "^9.1.6",
|
|
"model-redis": "^1.6.0",
|
|
"moment": "^2.30.1",
|
|
"mustache": "^4.2.0",
|
|
"node-fetch": "^2.7.0",
|
|
"node-nmap": "^4.0.0",
|
|
"nodemailer": "^9.0.0",
|
|
"p2psub": "^0.2.0",
|
|
"socket.io": "^4.8.3",
|
|
"ws": "^8.21.1",
|
|
"xss": "^1.0.15"
|
|
},
|
|
"license": "MIT",
|
|
"repository": {
|
|
"type": "git",
|
|
"url": "https://github.com/theta42/sso-manager-node.git"
|
|
},
|
|
"devDependencies": {
|
|
"jest": "^30.4.2",
|
|
"nodemon": "^3.1.11",
|
|
"supertest": "^7.2.2"
|
|
}
|
|
}
|